Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

96002 EPS Redis Client Implementation #19307

Merged
merged 16 commits into from
Nov 21, 2024
Merged

96002 EPS Redis Client Implementation #19307

merged 16 commits into from
Nov 21, 2024

Conversation

kanchanasuriya
Copy link
Contributor

Summary

  • Implementing redis client for storing EPS access token

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

NA

Acceptance criteria

  • I added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to 96002_CommunityCare_RedisClient_Implementation/main/main November 6, 2024 22:36 Inactive
randomsync
randomsync requested changes Nov 15, 2024
View reviewed changes
config/redis.yml Outdated Show resolved Hide resolved
modules/vaos/app/services/vaos/v2/eps/redis_client.rb Outdated Show resolved Hide resolved
modules/vaos/app/services/vaos/v2/eps/redis_client.rb Outdated Show resolved Hide resolved
modules/vaos/app/services/vaos/v2/eps/redis_client.rb Outdated Show resolved Hide resolved
modules/vaos/app/services/vaos/v2/eps/redis_client.rb Outdated Show resolved Hide resolved
@va-vfs-bot va-vfs-bot temporarily deployed to 96002_CommunityCare_RedisClient_Implementation/main/main November 15, 2024 19:09 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 96002_CommunityCare_RedisClient_Implementation/main/main November 19, 2024 00:33 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 96002_CommunityCare_RedisClient_Implementation/main/main November 19, 2024 01:52 Inactive
@kanchanasuriya kanchanasuriya marked this pull request as ready for review November 19, 2024 01:52
@kanchanasuriya kanchanasuriya requested review from a team as code owners November 19, 2024 01:52
@va-vfs-bot va-vfs-bot temporarily deployed to 96002_CommunityCare_RedisClient_Implementation/main/main November 20, 2024 20:46 Inactive
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Nov 20, 2024
Closed
@github-actions GitHub Actions
Copy link

Backend-review-group approval confirmed.

@kanchanasuriya kanchanasuriya merged commit 7e813ff into master Nov 21, 2024
26 checks passed
@kanchanasuriya kanchanasuriya deleted the 96002_CommunityCare_RedisClient_Implementation branch November 21, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

@cferris32 cferris32 cferris32 approved these changes

@randomsync randomsync randomsync approved these changes

Assignees
No one assigned
Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kanchanasuriya @randomsync @cferris32 @rjohnson2011 @va-vfs-bot